rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard

Tracking Issue: Fix auto-applicable lint suggestions by using multipart suggestions

Open flip1995 opened this issue 1 year ago • 1 comments

Description

#13098 introduced @no-rustfix annotations, that can be removed by changing the suggestion to a multipart suggestion:

//@no-rustfix: need to change the suggestion to a multipart suggestion

The affected test files are:

  • [ ] ui-toml/max_suggested_slice_pattern_length/index_refutable_slice.rs
  • [x] ui/crashes/ice-3717.rs
  • [ ] ui/derivable_impls.rs
  • [ ] ui/index_refutable_slice/if_let_slice_binding.rs
  • [ ] ui/index_refutable_slice/slice_indexing_in_macro.rs
  • [ ] ui/let_unit.rs
  • [ ] ui/manual_assert.rs
  • [ ] ui/manual_async_fn.rs
  • [ ] ui/manual_split_once.rs
  • [ ] ui/match_same_arms2.rs
  • [ ] ui/significant_drop_tightening.rs
  • [ ] ui/unnecessary_iter_cloned.rs
  • [ ] ui/unnecessary_to_owned.rs

To fix some of those:

  1. Pick one test and leave a comment about it
  2. Remove the @no-rustfix annotation
  3. Change the lint suggestion building to use multipart_suggestion over the current implementation
  4. write a comment here or mention this issue in the PR so that it gets marked as resolved.

Version

No response

Additional Labels

No response

flip1995 avatar Jul 15 '24 09:07 flip1995