rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard

Don't lint `assertions_on_constants` on any const assertions

Open tesuji opened this issue 1 year ago • 11 comments

changelog: Don't lint assertions_on_constants on any const assertions changelog: fix false-positive of unnecessary_operation lint in const contexts.

close #12816 close #12847 cc #12817

tesuji avatar May 24 '24 04:05 tesuji

r? @dswij

rustbot has assigned @dswij. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar May 24 '24 04:05 rustbot

It's been 2 weeks without new review Reassigning : r? y21

tesuji avatar Jun 05 '24 14:06 tesuji

Build fail as expected. In summary: body_const_context doesn't recognize const blocks. See https://github.com/rust-lang/rust/pull/125918 for more details

So waiting for next rustup... ~@rustbot block~

Edit: Nevermind, just bless the test

tesuji avatar Jun 08 '24 10:06 tesuji

rerolling r? @llogiq

tesuji avatar Jun 19 '24 13:06 tesuji

Looks ok to me. Thank you for staying the course.

@bors r+

llogiq avatar Jun 19 '24 21:06 llogiq

:pushpin: Commit 0d188f0a5a7d2b8a7a0ceb393b959b5516b12851 has been approved by llogiq

It is now in the queue for this repository.

bors avatar Jun 19 '24 21:06 bors

:hourglass: Testing commit 0d188f0a5a7d2b8a7a0ceb393b959b5516b12851 with merge 7de2cd790c47ad2e01e5f8fc52829daba702b5e8...

bors avatar Jun 19 '24 21:06 bors

:broken_heart: Test failed - checks-action_test

bors avatar Jun 19 '24 21:06 bors

Blessed the test after rustup !

tesuji avatar Jun 20 '24 01:06 tesuji

Can the build be rerun? I just ran into this issue.

SUPERCILEX avatar Jul 01 '24 03:07 SUPERCILEX

@llogiq Could we @bor retry again?

tesuji avatar Jul 01 '24 15:07 tesuji

Ok, here goes nothing:

@bors retry

llogiq avatar Jul 01 '24 20:07 llogiq

Ah, that won't work. I need to

@bors r+

again

llogiq avatar Jul 01 '24 22:07 llogiq

:pushpin: Commit a0234b4e8b8c58a8726ec64828c7144c910faf67 has been approved by llogiq

It is now in the queue for this repository.

bors avatar Jul 01 '24 22:07 bors

:hourglass: Testing commit a0234b4e8b8c58a8726ec64828c7144c910faf67 with merge c4125286cea8a4dcbb5df0e05f0d968a7d0c59d0...

bors avatar Jul 01 '24 22:07 bors

:sunny: Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test Approved by: llogiq Pushing c4125286cea8a4dcbb5df0e05f0d968a7d0c59d0 to master...

bors avatar Jul 01 '24 22:07 bors