Don't lint `assertions_on_constants` on any const assertions
changelog: Don't lint assertions_on_constants on any const assertions
changelog: fix false-positive of unnecessary_operation lint in const contexts.
close #12816 close #12847 cc #12817
r? @dswij
rustbot has assigned @dswij. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
It's been 2 weeks without new review Reassigning : r? y21
Build fail as expected. In summary: body_const_context doesn't recognize const blocks.
See https://github.com/rust-lang/rust/pull/125918 for more details
So waiting for next rustup... ~@rustbot block~
Edit: Nevermind, just bless the test
rerolling r? @llogiq
Looks ok to me. Thank you for staying the course.
@bors r+
:pushpin: Commit 0d188f0a5a7d2b8a7a0ceb393b959b5516b12851 has been approved by llogiq
It is now in the queue for this repository.
:hourglass: Testing commit 0d188f0a5a7d2b8a7a0ceb393b959b5516b12851 with merge 7de2cd790c47ad2e01e5f8fc52829daba702b5e8...
:broken_heart: Test failed - checks-action_test
Blessed the test after rustup !
Can the build be rerun? I just ran into this issue.
@llogiq Could we @bor retry again?
Ok, here goes nothing:
@bors retry
Ah, that won't work. I need to
@bors r+
again
:pushpin: Commit a0234b4e8b8c58a8726ec64828c7144c910faf67 has been approved by llogiq
It is now in the queue for this repository.
:hourglass: Testing commit a0234b4e8b8c58a8726ec64828c7144c910faf67 with merge c4125286cea8a4dcbb5df0e05f0d968a7d0c59d0...
:sunny: Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test Approved by: llogiq Pushing c4125286cea8a4dcbb5df0e05f0d968a7d0c59d0 to master...