rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard

Allow more attributes in `clippy::useless_attribute`

Open 9999years opened this issue 1 year ago • 5 comments

Fixes #12753 Fixes #4467 Fixes #11595 Fixes #10878

changelog: [useless_attribute]: Attributes allowed on use items now include ambiguous_glob_exports, hidden_glob_reexports, dead_code, unused_braces, and clippy::disallowed_types.

9999years avatar May 02 '24 19:05 9999years

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar May 02 '24 19:05 rustbot

@rustbot review

9999years avatar May 02 '24 19:05 9999years

Thank you for the PR and welcome to Clippy :tada: I'll take a look at it soon, most likely during the weekend :D

@GuillaumeGomez If you have the time, you could do a prereview :D

xFrednet avatar May 02 '24 21:05 xFrednet

@rustbot review

9999years avatar May 02 '24 21:05 9999years

Sure!

GuillaumeGomez avatar May 03 '24 09:05 GuillaumeGomez

@rustbot review

9999years avatar May 06 '24 19:05 9999years

Looks good to me, thank you for the changes!

@bors r=xFrednet,GuillaumeGomez

xFrednet avatar May 06 '24 20:05 xFrednet

:pushpin: Commit 566bfff8bb36eb4d52a637e28732ab38439491c5 has been approved by xFrednet,GuillaumeGomez

It is now in the queue for this repository.

bors avatar May 06 '24 20:05 bors

:hourglass: Testing commit 566bfff8bb36eb4d52a637e28732ab38439491c5 with merge befb659145a734e51a3708ff84315ae07123c880...

bors avatar May 06 '24 20:05 bors

:sunny: Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test Approved by: xFrednet,GuillaumeGomez Pushing befb659145a734e51a3708ff84315ae07123c880 to master...

bors avatar May 06 '24 20:05 bors