rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard

make [`manual_map`] ignore types that contain `dyn`

Open J-ZhengLi opened this issue 10 months ago • 6 comments

fixes: #12659

[manual_map] and [manual_filter] shares the same check logic, but this issue doesn't seems like it could affect manual_filter (?)


changelog: make [manual_map] ignore types that contain dyn

J-ZhengLi avatar Apr 25 '24 03:04 J-ZhengLi

r? @dswij

rustbot has assigned @dswij. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Apr 25 '24 03:04 rustbot

@rustbot ready

J-ZhengLi avatar May 10 '24 08:05 J-ZhengLi

Hey, this is a ping from triage. @dswij can you give this PR a review? It's totally fine if you don't have the time right now, you can reassign the PR to a random team member using r? clippy.

@rustbot ready

xFrednet avatar Jun 20 '24 20:06 xFrednet

I'll take this one since I looked into it previously, r? me

Alexendoo avatar Jun 21 '24 18:06 Alexendoo

Failed to set assignee to me: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

rustbot avatar Jun 21 '24 18:06 rustbot

~~I need more time on this~~

@rustbot author

J-ZhengLi avatar Jun 29 '24 10:06 J-ZhengLi