rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard

fix [`undocumented_unsafe_blocks`] FP with trait/impl items

Open J-ZhengLi opened this issue 10 months ago • 5 comments

fixes: #11709 close: #12720

do-over of #11813 , I was trying to fix multiple problems at once thus making that PR hard to review, also hard to maintain after so many conflicts... So, here's a new one, should be a bit simpler to review the changes.

r? @Alexendoo if you don't mind?


changelog: fix [undocumented_unsafe_blocks] FP with trait/impl items

J-ZhengLi avatar Apr 12 '24 08:04 J-ZhengLi

Hey, this is a ping from triage. @Alexendoo can you give this PR a review? It's totally fine if you don't have the time right now, you can reassign the PR to a random team member using r? clippy.

@rustbot ready

xFrednet avatar Aug 03 '24 08:08 xFrednet

I believe https://github.com/rust-lang/rust-clippy/pull/12672#discussion_r1647561890 still applies here

Alexendoo avatar Aug 03 '24 11:08 Alexendoo

Okay, then a ping to @J-ZhengLi, have you seen the referenced comment?

@rustbot author

xFrednet avatar Aug 03 '24 16:08 xFrednet

Okay, then a ping to @J-ZhengLi, have you seen the referenced comment?

@rustbot author

Ahh yes, sorry I have some time sensitive task for my job lately, is it ok if I left this PR hang for 2 more weeks? I should have more time at the end of August, so I can finally got back to clippy by then :D.

J-ZhengLi avatar Aug 16 '24 16:08 J-ZhengLi

Yeah, no problem, IRL stuff comes first! :D

xFrednet avatar Aug 18 '24 09:08 xFrednet