rust-clippy
rust-clippy copied to clipboard
rust-lang
Handle false positive with `map_clone` lint
Summary
- Fixes https://github.com/rust-lang/rust-clippy/issues/12271
- (This is my first contribution to clippy and any suggestion would be appreciated)
changelog: [map_clone]: Handle false positive with map_clone lint
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) some time within the next two weeks.
Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:
-
@rustbot author: the review is finished, PR author should check the comments and take action accordingly -
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
r? xFrednet (oh I didn't know this can't be used for already assigned people)
Could not assign reviewer from: xFrednet.
User(s) xFrednet are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.
:umbrella: The latest upstream changes (presumably #12306) made this pull request unmergeable. Please resolve the merge conflicts.
Failed to set assignee to xFrednet~~: invalid assignee
Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.
Could not assign reviewer from: xFrednet.
User(s) xFrednet are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.
Hey, sorry, this PR got lost in my inbox :see_no_evil:
This version looks good, I added one comment, to your question. Once we've checked this, we can merge the PR.
:pushpin: Commit 5f8d8f165606775fcf81dfb27ac9de19f60a7bee has been approved by xFrednet
It is now in the queue for this repository.
:hourglass: Testing commit 5f8d8f165606775fcf81dfb27ac9de19f60a7bee with merge a75e271a65ff36a71dd4372551653ea3aca6e85d...
:sunny: Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test Approved by: xFrednet Pushing a75e271a65ff36a71dd4372551653ea3aca6e85d to master...