rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard

fix [`undocumented_unsafe_block`] and [`unnecessary_safety_comment`] not detecting associated constants

Open J-ZhengLi opened this issue 1 year ago • 5 comments

fixes: #11709

changelog: fix FP on [undocumented_unsafe_block] and [unnecessary_safety_comment]

J-ZhengLi avatar Nov 15 '23 06:11 J-ZhengLi

r? @blyxyas

(rustbot has picked a reviewer for you, use r? to override)

rustbot avatar Nov 15 '23 06:11 rustbot

Sorry, I don't really have the time to review a PR with this size (=^-ω-^=) I have some important deadlines before mid-december and a lot of work. Sorry for the wait :heart:

r? @rust-lang/clippy

blyxyas avatar Nov 22 '23 11:11 blyxyas

Sorry, I don't really have the time to review a PR with this size (=^-ω-^=) I have some important deadlines before mid-december and a lot of work. Sorry for the wait ❤️

r? @rust-lang/clippy

No worries~

J-ZhengLi avatar Nov 22 '23 12:11 J-ZhengLi

:umbrella: The latest upstream changes (presumably #11903) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Dec 01 '23 17:12 bors

:umbrella: The latest upstream changes (presumably #12306) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Feb 19 '24 09:02 bors

Hey @J-ZhengLi, this is a ping from triage, since there hasn't been any activity in some time. Could you rebase on master?

@rustbot author

xFrednet avatar Apr 01 '24 09:04 xFrednet

Oh nooo, because I already forgot what I did thus it's kinda hard to distinguish which lines are mine and which are add by others after this PR, at this point it might even be easier if I redo the whole thing (but with less changes I promise). It should be a simple fix tho, I don't know what have I done to make it this complicated 🤦‍♂️

I'm gonna close this and open a new PR tomorrow (hopefully) fixing this again, and sorry @Alexendoo for wasting effort XD

J-ZhengLi avatar Apr 03 '24 15:04 J-ZhengLi