rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

new lint that detects blocking operations in async

Open J-ZhengLi opened this issue 1 year ago • 11 comments

fixes: #10794

changelog: new lint [unnecessary_blocking_ops]

Ok, this is a rough one, I have no confident in many things (the name ofc), and there are certain things I wanna address before I put too much effort in it.

J-ZhengLi avatar Sep 28 '23 09:09 J-ZhengLi

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

rustbot avatar Sep 28 '23 09:09 rustbot

:umbrella: The latest upstream changes (presumably #11527) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Sep 29 '23 03:09 bors

:umbrella: The latest upstream changes (presumably #11685) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Oct 24 '23 12:10 bors

:umbrella: The latest upstream changes (presumably #11791) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Nov 14 '23 16:11 bors

:umbrella: The latest upstream changes (presumably #10283) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Dec 29 '23 11:12 bors

:umbrella: The latest upstream changes (presumably #12144) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Jan 20 '24 23:01 bors

Hey @Jarcho, this is a ping from triage. Can you give this PR a review? It's totally fine if you don't have the time right now, you can reassign the PR to a random team member using r? clippy.

@J-ZhengLi could you rebase on master again? Since only conf.rs and lib.rs need to be updated it should be safe to already review this :D

@rustbot ready

xFrednet avatar Mar 31 '24 11:03 xFrednet

... @J-ZhengLi could you rebase on master again? Since only conf.rs and lib.rs need to be updated it should be safe to already review this :D ...

yeah sure, I forgot about this one, still feel very unconfident about this one, running lintcheck gives nothing lol (maybe because not many of those use async at all).

J-ZhengLi avatar Apr 01 '24 02:04 J-ZhengLi

I believe none of the lints in lintcheck use async extensively, but I could be wrong.

xFrednet avatar Apr 01 '24 09:04 xFrednet

:umbrella: The latest upstream changes (presumably #12635) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Apr 12 '24 19:04 bors

Hey, this is a ping from triage. @Jarcho can you give this PR a review? It's totally fine if you don't have the time right now, you can reassign the PR to a random team member using r? clippy.

@J-ZhengLi Sorry for the wait, could you rebase this PR?

@rustbot ready

xFrednet avatar Jun 20 '24 20:06 xFrednet

Looking at current implementation, combining with the other issue #4377, I kinda want to close this and maybe re-work on it later :thinking:

J-ZhengLi avatar Jul 08 '24 02:07 J-ZhengLi