rust-bindgen icon indicating copy to clipboard operation
rust-bindgen copied to clipboard
verified publisher icon rust-lang

Avoid \u{1} prefix when the user overrode item names

Open bjorn3 opened this issue 9 months ago • 3 comments

\u{1} is an LLVM specific extension which other rustc codegen backends do not support.

Fixes https://github.com/rust-lang/rust-bindgen/issues/2935

bjorn3 avatar Mar 20 '25 15:03 bjorn3

Why does the Publish on crates.io workflow get invoked even though this PR hasn't been merged? It gives me a failure notification. https://github.com/rust-lang/rust-bindgen/actions/runs/13972867609

bjorn3 avatar Mar 20 '25 15:03 bjorn3

Right, for Mach-O all symbols get mangled to add an _ prefix. Is there a way in libclang to get the symbol name before the object file format specific mangling but after C++ mangling? (aka the input LLVM expects then not using \u{1})

bjorn3 avatar Mar 20 '25 15:03 bjorn3

Why does the Publish on crates.io workflow get invoked even though this PR hasn't been merged? It gives me a failure notification. https://github.com/rust-lang/rust-bindgen/actions/runs/13972867609

cc @pvdrz . My understanding is that it's not supposed to run, but maybe these fields are an or rather than an and:

https://github.com/rust-lang/rust-bindgen/blob/a50a2cf07ba26153c822ee858c0a022532ac87a4/.github/workflows/publish.yml#L3-L8

emilio avatar Apr 04 '25 14:04 emilio