Fix generated constants: f64::INFINITY & f64::NEG_ INFINITY

Open gabiganam opened this issue 1 year ago • 3 comments

https://github.com/rust-lang/rust-bindgen/issues/2853

Jun 25 '24 07:06 gabiganam

I'm not sure of Bindgen's MSRV policy for generated crates, but these constants require at least Rust 1.43.

If that's the case, there should be a new variant in RustTarget representing 1.43 and this change should be gated behind a feature that enables if the target version is larger or equal than 1.43

Jun 25 '24 21:06 pvdrz

I'm not sure of Bindgen's MSRV policy for generated crates, but these constants require at least Rust 1.43.

If that's the case, there should be a new variant in RustTarget representing 1.43 and this change should be gated behind a feature that enables if the target version is larger or equal than 1.43

Updated the PR, hope this is what you meant.

Jun 26 '24 07:06 gabiganam

@gabiganam requested a review from @madsmtm

Sorry, I'm the wrong person to ask for this, I'm not a maintainer here.

Jun 27 '24 14:06 madsmtm