rust-bindgen
rust-bindgen copied to clipboard
Fix const array issue
Fix #2683. Fairly hacky fix right now, but it doesn't seem to break any tests.
@rsammelson can you explain the test changes? The diff shows these files changed
.../tests/constified-enum-module-overflow.rs | 15 ++++++++++++-
.../tests/issue-544-stylo-creduce-2.rs | 2 +-
.../libclang-9/ptr32-has-different-size.rs | 6 +++---
.../expectations/tests/struct_typedef_ns.rs
But none of those seem to have anything to do with const/mut pointers
I'm not sure what caused that change, let me fix it.
@tgross35 It should be fixed now.
Thanks. Could you add a test for the change you made?
The changes before are because of newer libclang versions. We should update CI and expectations to newer libclang IMO. But not in this patch of course.
@tgross35 I don't understand why the tests are failing.
Yeah, the unused_imports
don't seem like your fault. Maybe something in CI changed recently.
I'll test it out here https://github.com/rust-lang/rust-bindgen/pull/2763.
Not sure where those errors appeared from but the changes in https://github.com/rust-lang/rust-bindgen/pull/2763 seem to fix them. @emilio might know more.
You don't have to do anything except rebase whenever that is merged.
Not sure where those errors appeared from but the changes in #2763 seem to fix them. @emilio might know more.
Yeah, we use rust stable so whenever a rust update introduce warnings we hit this. Should be fixed now tho.
(I tried to do it automatically, let's see)