rust-bindgen icon indicating copy to clipboard operation
rust-bindgen copied to clipboard

Added support for dynamic loading of variables

Open pradt2 opened this issue 3 years ago • 5 comments

This expands support for dynamic loading to support dynamically loaded variables.

This PR addresses my own grievance - issue #2113. It plays nicely with --dynamic-link-require-all. I tried to mirror the approach used to support dynamically loaded functions.

It's my first contribution to this project, all feedback welcome.

pradt2 avatar Nov 04 '21 18:11 pradt2

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

highfive avatar Nov 04 '21 18:11 highfive

Hey, thanks for looking at this.

Sure, I can try to add some tests. Would you rather have me add them here, or merge this and open a separate PR?

@emilio

pradt2 avatar Nov 26 '21 10:11 pradt2

Let's add them here, so the code doesn't land untested.

emilio avatar Nov 26 '21 11:11 emilio

@emilio Sorry it took this long, I've added some tests. Let me know if there's anything outstanding still

pradt2 avatar Jan 28 '22 16:01 pradt2

:umbrella: The latest upstream changes (presumably 310f7f877042f0858cd01fb1c326a41d23bd821c) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo avatar Mar 15 '22 03:03 bors-servo

@pradt2 do you have time to rebase this? I can do it if that's not the case

pvdrz avatar Sep 22 '22 20:09 pvdrz

@pvdrz done

pradt2 avatar Sep 23 '22 08:09 pradt2

:umbrella: The latest upstream changes (presumably #2284) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo avatar Oct 05 '22 01:10 bors-servo