rust-analyzer icon indicating copy to clipboard operation
rust-analyzer copied to clipboard

Show parameter hint for the missing argument?

Open matklad opened this issue 4 years ago • 4 comments

image

Seems like we can show tdpp hint before the cursor here?

matklad avatar Jul 04 '21 10:07 matklad

@ChayimFriedman2 @ShoyuVanilla @Veykril I have raised for this issue. Hope you give it a review. Thanks !

benodiwal avatar Dec 10 '25 22:12 benodiwal

@benodiwal Tagging maintainers, and doubly so almost all of them, for a PR that is just 10 hours old, is inappropriate. We volunteer here, reviewing PRs when we have the time and will, and there is a long queue currently. If your PR was sitting without response in the order of weeks, then it's fine to tag @rust-lang/rust-analyzer. Otherwise, please do not tag maintainers unless they were previously involved with the PR, for example they requested you to perform some changes and you completed them.

ChayimFriedman2 avatar Dec 10 '25 22:12 ChayimFriedman2

Got it. Sorry about the unnecessary tags 🙏! Still learning the norms here in this project, won’t repeat it going forward. Thanks for pointing it out.

benodiwal avatar Dec 10 '25 22:12 benodiwal

Personally, I don’t mind being tagged, but it doesn’t make much difference in practice because:

  • I’m already subscribed to most events on the rust-analyzer repository (new issues, comments, PRs), so I get notifications regardless of tagging.
  • I haven’t been spending much time on rust-analyzer recently. I hope to pick it up again toward the end of the year, but for now I may not be able to review many PRs 😅

ShoyuVanilla avatar Dec 11 '25 10:12 ShoyuVanilla