rust-analyzer icon indicating copy to clipboard operation
rust-analyzer copied to clipboard

Invalid macro error persists after restart

Open SunkenPotato opened this issue 6 months ago • 3 comments

rust-analyzer version: 1.88.0-nightly (0fe8f345 2025-04-10)

rustc version: 1.88.0-nigtly (0fe8f345 2025-04-10)

editor or extension: Zed

relevant settings: N/A

repository link (if public, optional): /

code snippet to reproduce:

macro_rules! example {
    (
        $(#[$attr:meta])*
        $visibility:vis enum $name:ident {
            $(
                $(#[$variant_attr:meta])*
                #($message:expr)
                $variant_name:ident $( ( $($variant_type:ty),* ) )?
            ),*
        }
    ) => {

        $(#[$attr])*
        $visibility enum $name {
            $(
                $(#[$variant_attr])*
                $variant_name $((
                    $($variant_type),*
                ))?,
            )*
        }

        impl $name {
            pub fn get_message(&self) -> &'static str {
                match self {
                    $(
                        Self:: $variant_name $( ($(only_second!($variant_type | _))*) )? => $message
                    )*
                }
            }
        }
    };
}

macro_rules! only_second {
    ($first:tt | $second:tt) => {
        $second
    };
}

example! {
    /// foo
    pub enum A {
        /// bar
        #("Hello, world")
        Variant(&'static str)
    }
}

RA will display an error under &'static str in A::Variant:

unexpected token in input (rust-analyzer macro-error)

SunkenPotato avatar Jun 19 '25 13:06 SunkenPotato

Hmm, this doesn't reproduce for me.

flodiebold avatar Jun 19 '25 14:06 flodiebold

It does reproduce for me.

ChayimFriedman2 avatar Jun 19 '25 14:06 ChayimFriedman2

It seems that the problem is that after something is captured (in this case as a ty), it can be captured as one tt, but we don't respect that.

ChayimFriedman2 avatar Jun 19 '25 14:06 ChayimFriedman2

I get a similar problem in https://github.com/teymour-aldridge/shorthair where rust-analyzer expands a macro (using the "expand macro recursively" action) as

diesel_migrations::EmbeddedMigrations::new(&[diesel_migrations::EmbeddedMigration::new(,Some(),diesel_migrations::EmbeddedName::new(-"11-14-022138_init"),diesel_migrations::TomlMetadataWrapper::new(true)),diesel_migrations::EmbeddedMigration::new(,Some(),diesel_migrations::EmbeddedName::new(-"04-17-230542_make_user_email_unique"),diesel_migrations::TomlMetadataWrapper::new(true)),diesel_migrations::EmbeddedMigration::new(,Some(),diesel_migrations::EmbeddedName::new(-"04-28-180834_make_user_username_unique"),diesel_migrations::TomlMetadataWrapper::new(true)),diesel_migrations::EmbeddedMigration::new(,Some(),diesel_migrations::EmbeddedName::new(-"04-29-231157_make_spar_series_join_requests_unique"),diesel_migrations::TomlMetadataWrapper::new(true)),diesel_migrations::EmbeddedMigration::new(,Some(),diesel_migrations::EmbeddedName::new(-"05-02-010712_draw_management"),diesel_migrations::TomlMetadataWrapper::new(true)),diesel_migrations::EmbeddedMigration::new(,Some(),diesel_migrations::EmbeddedName::new(-"05-02-011237_partner_preferences"),diesel_migrations::TomlMetadataWrapper::new(true)),])

whereas running cd crates/main && cargo expand --lib ::MIGRATIONS outputs

pub const MIGRATIONS: EmbeddedMigrations = diesel_migrations::EmbeddedMigrations::new(
    &[
        diesel_migrations::EmbeddedMigration::new(
            "shortened version of original string",
            Some(
                "shortened version of original string",
            ),
            diesel_migrations::EmbeddedName::new("2024-11-14-022138_init"),
            diesel_migrations::TomlMetadataWrapper::new(true),
        ),
        diesel_migrations::EmbeddedMigration::new(
            "shortened version of original string",
            Some("shortened version of original string"),
            diesel_migrations::EmbeddedName::new(
                "2025-04-17-230542_make_user_email_unique",
            ),
            diesel_migrations::TomlMetadataWrapper::new(true),
        ),
        diesel_migrations::EmbeddedMigration::new(
            "shortened version of original string",
            Some(
                "shortened version of original string",
            ),
            diesel_migrations::EmbeddedName::new(
                "2025-04-28-180834_make_user_username_unique",
            ),
            diesel_migrations::TomlMetadataWrapper::new(true),
        ),
        diesel_migrations::EmbeddedMigration::new(
            "shortened version of original string",
            Some(
                "shortened version of original string",
            ),
            diesel_migrations::EmbeddedName::new(
                "2025-04-29-231157_make_spar_series_join_requests_unique",
            ),
            diesel_migrations::TomlMetadataWrapper::new(true),
        ),
        diesel_migrations::EmbeddedMigration::new(
            "shortened version of original string",
            Some(
                "shortened version of original string",
            ),
            diesel_migrations::EmbeddedName::new("2025-05-02-010712_draw_management"),
            diesel_migrations::TomlMetadataWrapper::new(true),
        ),
        diesel_migrations::EmbeddedMigration::new(
            "shortened version of original string",
            Some(
                "shortened version of original string",
            ),
            diesel_migrations::EmbeddedName::new(
                "2025-05-02-011237_partner_preferences",
            ),
            diesel_migrations::TomlMetadataWrapper::new(true),
        ),
    ],
);

(note: I have replaced long strings with "shortened version of original string")

teymour-aldridge avatar Jun 27 '25 23:06 teymour-aldridge