rfcs icon indicating copy to clipboard operation
rfcs copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

RFC: Reserve unprefixed guarded string literals in Edition 2024

Open pitaj opened this issue 1 year ago • 7 comments

Beginning with the 2024 edition, reserve the syntax #"foo"#, as a way of future-proofing against future language changes.

Rendered

Note: much of the text of this RFC is directly adapted from #3101. Thank you to @bstrie and all other contributors there for paving the path.

pitaj avatar Mar 25 '24 03:03 pitaj

@rustbot label +T-lang

pitaj avatar Mar 25 '24 03:03 pitaj

Very much in favor of reserving this syntax.

Starting an FCP so we can check for consensus asynchronously, in addition to discussing this at a future meeting.

@rfcbot merge

joshtriplett avatar Mar 25 '24 10:03 joshtriplett

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

  • [x] @joshtriplett
  • [x] @nikomatsakis
  • [x] @pnkfelix
  • [x] @scottmcm
  • [x] @tmandry

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns. See this document for info about what commands tagged team members can give me.

rfcbot avatar Mar 25 '24 10:03 rfcbot

:bell: This is now entering its final comment period, as per the review above. :bell:

rfcbot avatar Apr 03 '24 15:04 rfcbot

@rfcbot reviewed

It would be nice if we could do a crater run to tell the impact on any macros, but +1 to reserving the syntax in any case.

tmandry avatar Apr 03 '24 15:04 tmandry

@rustbot labels -I-lang-nominated

We discussed this in the meeting on 2024-04-03 and people wanted to see this happen. Thanks to @pitaj for separating this out and putting this forward.

traviscross avatar Apr 05 '24 05:04 traviscross

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

rfcbot avatar Apr 13 '24 15:04 rfcbot

The lang team has accepted this RFC, and we've now merged it.

Thanks to @pitaj for pushing this forward, and thanks to all those who reviewed this RFC and provided helpful feedback.

For further updates on this work, follow the tracking issue:

  • https://github.com/rust-lang/rust/issues/123735

traviscross avatar May 06 '24 05:05 traviscross