rfcbot-rs icon indicating copy to clipboard operation
rfcbot-rs copied to clipboard

Assign team member who proposed fcp

Open tmandry opened this issue 10 months ago • 1 comments

I found it really helpful when @dtolnay assigned me to https://github.com/rust-lang/rust/pull/115333 after I proposed fcp merge. This caused the PR notifications to show up in my "assigned" category and reinforced that I was the lang team member "shepherding" it through.

Additionally, when we manually merge RFCs and PRs after FCP is complete, we usually leave it up to the person who started the FCP.

I think we should automate and formalize this by having triagebot assign the FCP proposer.

tmandry avatar Oct 18 '23 22:10 tmandry

Additionally, when we manually merge RFCs and PRs after FCP is complete, we usually leave it up to the person who started the FCP.

Do we? I was involved in several FPCs on implementation-heavy PRs. Review is usually done by someone from the compiler team, but it needs t-lang FCP so the FCP proposer is a t-lang member.

I think there are many PRs where assigning the FCP proposer does not make a lot of sense.

RalfJung avatar Nov 03 '23 15:11 RalfJung