rfcbot-rs icon indicating copy to clipboard operation
rfcbot-rs copied to clipboard

"review" -> "FCP approval" or similar in @rfcbot merge message

Open Havvy opened this issue 6 years ago • 3 comments

The message today states "Team member @ghosthas proposed to merge this. The next step is review by the rest of the tagged teams:". Review is imprecise because it can sort of imply code review. By changing to explicitly state what is being asked, we can avoid some confusion.

Havvy avatar Sep 15 '18 07:09 Havvy

I agree that the current wording is too vague, but I'm not sure that "FCP approval" is the phrase I would choose to replace it. Can you think of an option you'd find clearer that doesn't rely on any Rust-governance-process-specific jargon?

anp avatar Sep 17 '18 17:09 anp

I think the implication of code review is exactly the right analogy personally. The team responsible should review the document and associated discussion to reach a conclusion.

Centril avatar Sep 17 '18 17:09 Centril

"review and approval" seems reasonable, but I agree with @Centril that we want to keep the implication of "review this carefully".

joshtriplett avatar Sep 18 '18 03:09 joshtriplett