rfcbot-rs icon indicating copy to clipboard operation
rfcbot-rs copied to clipboard

Noting @rfcbot concerns before PFCP has started

Open Centril opened this issue 7 years ago • 2 comments

Might be nice for team members to be able to note concerns they have when they first read an RFC before some other team member decides to @rfcbot fcp merge/close/postpone a proposal so that they save some time.

Context: https://github.com/rust-lang/rfcs/pull/2442#issuecomment-389652120

Centril avatar May 16 '18 23:05 Centril

I think this definitely could be good, although probably makes the data model a bit more complicated.

I have not fully thought through the impact it may have on how conversations work. For one thing, many RFCs change substantially in between initially being posted and when FCP occurs. I can also see the discussion changing drastically from a team member registering a blocking concern before it's been discussed with other team members.

cc @aturon

anp avatar May 17 '18 20:05 anp

although probably makes the data model a bit more complicated.

So I was thinking that you'd add another table top_concern to the schema and it would be per issue... Then, the bot would take those into account when rendering things and checking if an RFC can make progress or not.

Centril avatar May 18 '18 18:05 Centril