reference icon indicating copy to clipboard operation
reference copied to clipboard

Document how closure capturing interacts with discriminant reads

Open meithecatte opened this issue 7 months ago • 8 comments

This is the behavior after the bugfixes in rust-lang/rust#138961. I have successfully ran mdbook test with RUSTUP_TOOLCHAIN pointed at a stage1 built on top of the aforementioned PR – until it's merged, the CI here will fail.

meithecatte avatar May 30 '25 21:05 meithecatte

I've reworded the slice and range sections to not use the "discriminant read" term, do you think this is clearer?

meithecatte avatar Jul 11 '25 16:07 meithecatte

This looks good for me, could someone with authority approve this plz?

Nadrieril avatar Oct 03 '25 11:10 Nadrieril

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot avatar Oct 07 '25 06:10 rustbot

Thanks. Reviewing.

traviscross avatar Oct 07 '25 17:10 traviscross

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot avatar Oct 14 '25 05:10 rustbot

This PR was in good shape. Thanks to @meithecatte for that and to @Nadrieril for the review of it. I've pushed some mostly editorial adjustments. Please have a look, of course, for any errors. I'll ask @ehuss to have a look at well on our lang-docs call. Overall, though, this is OK to go forward, so we can mark this as approved and unblock the underlying stabilization.

traviscross avatar Oct 14 '25 05:10 traviscross

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot avatar Oct 14 '25 23:10 rustbot

EDIT: nevermind, moved this to another issue

Nadrieril avatar Oct 20 '25 12:10 Nadrieril