reference icon indicating copy to clipboard operation
reference copied to clipboard

Clarify requires of Prefix/Directive validity requirements

Open chorman0773 opened this issue 1 year ago • 3 comments

This alters the text of the inline-assembly chapter to clarify that ending an inline-assembly block with a prefix or using a "stateful" assembly directive without reverting it results in undefined results whenever the program is executed at all - even if it doesn't eventually evaluate (let alone return from) the assembly block. It also notes that the compiler may (though does not currently) diagnose improper uses of stateful assembly directives that would violate that point.

This also removes the specific application of the prefix to x86 - I do not know whether this applies to any existing supported architectures, but it future proofs adding new such architectures.

Editorially, it also moves the aforementioned rules into the [asm.validity] section, and renames the identifiers accordingly.

CC: @Amanieu

chorman0773 avatar Aug 26 '24 00:08 chorman0773

:umbrella: The latest upstream changes (possibly f80986bb34aa67f30bbb6b92f7b69b250e275126) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot avatar Jan 14 '25 17:01 rustbot

@chorman0773 Just checking in, is this something you want to continue working on?

ehuss avatar Mar 13 '25 14:03 ehuss

Yes, I just haven't had much time to work on it.

chorman0773 avatar Mar 13 '25 19:03 chorman0773