reference icon indicating copy to clipboard operation
reference copied to clipboard

Guarantee repr(C) enum discriminants are stable within a compilation

Open joshlf opened this issue 1 year ago • 7 comments

joshlf avatar Jan 25 '24 00:01 joshlf

cc @djkoloski @jswrenn

joshlf avatar Jan 25 '24 00:01 joshlf

Friendly ping 🙂

joshlf avatar Mar 02 '24 22:03 joshlf

Friendly ping 🙂

joshlf avatar May 20 '24 17:05 joshlf

Is there some context for this change? Has it been discussed by the lang team?

ehuss avatar May 20 '24 17:05 ehuss

Has it been discussed by the lang team?

No, but I figured it'd be pretty uncontroversial. Happy to CC them here if you'd like.

joshlf avatar May 20 '24 17:05 joshlf

@joshlf: Before we lang nominate it, could you update the PR description with a summary of the change being proposed here and describe in some detail the motivations for this change. E.g., if you could go into more detail about the situation you have with the zerocopy library and what the possible solutions for that problem are (especially if there are any other ones than the one proposed here), that would be helpful.

If you have any ideas for how we would actually encode this as a test in our test suite, that would be good to detail also.

traviscross avatar Jul 09 '24 22:07 traviscross