reference icon indicating copy to clipboard operation
reference copied to clipboard

Update object safety to match impl around self as receiver

Open upsuper opened this issue 3 years ago • 6 comments

This fixes #1247.

upsuper avatar Aug 13 '22 11:08 upsuper

Also, change the description so that it just says "fixes #1247". The prefix means it won't autoclose the issue when this is merged.

I don't think that's true: image

upsuper avatar Aug 14 '22 07:08 upsuper

(And I blame Github not showing a visual indicator on that. I remember it showing a dashed underline in the past.)

It does show a dashed underline for me, and the line disappear when I hover it to show the tooltip.

upsuper avatar Aug 14 '22 07:08 upsuper

@ehuss @Havvy Any other thought?

upsuper avatar Sep 29 '22 11:09 upsuper

We reviewed this PR in the rustdocs call, and we've asked for review of this by the types team in:

  • https://github.com/rust-lang/rust/issues/127251

traviscross avatar Jul 02 '24 22:07 traviscross