reference icon indicating copy to clipboard operation
reference copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

Add documentation for raw-dylib and link_ordinal

Open dpaoliello opened this issue 3 years ago • 0 comments

  • Documents the raw-dylib link kind (https://github.com/rust-lang/rust/issues/58713), including how it differs from dylib.
  • Documents the link_ordinal attribute (https://github.com/rust-lang/rust/pull/89025).

dpaoliello avatar Jul 29 '22 17:07 dpaoliello

@ehuss or @michaelwoerister can I please get a review?

dpaoliello avatar Aug 24 '22 22:08 dpaoliello

Seems fine to me. It looks like there is an exception for x86 that isn't mentioned here. Perhaps a small note like "is only supported on Windows and is not supported on target_arch="x86"" or something like that.

Merging this has to wait for the rust stabilization PR to merge.

ehuss avatar Aug 25 '22 01:08 ehuss

Seems fine to me. It looks like there is an exception for x86 that isn't mentioned here. Perhaps a small note like "is only supported on Windows and is not supported on target_arch="x86"" or something like that.

Merging this has to wait for the rust stabilization PR to merge.

@ehuss The stabilization PR has been merged, and I added a not about being unsupported on x86.

dpaoliello avatar Sep 12 '22 17:09 dpaoliello