reference icon indicating copy to clipboard operation
reference copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

panic runtime and C-unwind documentation

Open BatmanAoD opened this issue 3 years ago • 25 comments

Tracking issue: https://github.com/rust-lang/rust/issues/74990

BatmanAoD avatar May 29 '22 02:05 BatmanAoD

Hm... not sure how to fix the links to the newly-introduced page. Is there an index page I need to edit?

Edit: I think I found it

BatmanAoD avatar May 30 '22 17:05 BatmanAoD

Hm...the panic information in runtime.md should be edited as well.

BatmanAoD avatar May 30 '22 17:05 BatmanAoD

Sorry for the delay; I think I've addressed all comments.

BatmanAoD avatar Feb 04 '23 23:02 BatmanAoD

@tmandry @nikomatsakis I'm not sure you saw my comments & changes last week, but I think this is ready for re-review.

BatmanAoD avatar Feb 12 '23 19:02 BatmanAoD

Could you squash the commits?

nbdd0121 avatar Feb 12 '23 19:02 nbdd0121

@nbdd0121 Can that be done on merge? I've heard that GitHub sometimes has trouble with PR branches that receive force-pushes.

BatmanAoD avatar Feb 12 '23 19:02 BatmanAoD

I think I've resolved all open questions and concerns. Is there anything else needed from me at the moment?

BatmanAoD avatar Mar 26 '23 22:03 BatmanAoD

This really needs rebasing now.

nbdd0121 avatar Aug 26 '23 14:08 nbdd0121

@nbdd0121 Done!

BatmanAoD avatar Aug 26 '23 18:08 BatmanAoD

@tmandry two changes since your review:

  • I added the new ABIs to items/external-blocks
  • I added that catching an exception or unwind from the "wrong" language is UB

BatmanAoD avatar Sep 03 '23 19:09 BatmanAoD

@tmandry @ehuss can this be merged, since the partial stabilization was a while ago now?

BatmanAoD avatar Oct 17 '23 22:10 BatmanAoD