miri icon indicating copy to clipboard operation
miri copied to clipboard

remove some SSE/SSE2 intrinsics that are no longer used by stdarch

Open RalfJung opened this issue 1 year ago • 4 comments

Fixes https://github.com/rust-lang/miri/issues/3691

RalfJung avatar Jul 13 '24 16:07 RalfJung

Blocked on https://github.com/rust-lang/stdarch/pull/1584 propagating to the rustc repo.

RalfJung avatar Jul 13 '24 16:07 RalfJung

The stdarch patch will also ensure that the "sqrt.ps.256" case in https://github.com/rust-lang/miri/blob/master/src/shims/x86/avx.rs#L78 will never be reached. This case is still present here.

TDecking avatar Jul 15 '24 16:07 TDecking

Yeah, but sqrt is implemented together with two other functions there so there's not really any code saved by removing that... :shrug:

The same goes for sse.sqrt.ss, sse.sqrt.ps.

RalfJung avatar Jul 15 '24 17:07 RalfJung

Hm I guess this removes all uses of FloatUnaryOp::Sqrt. So maybe it's worth it after all.

RalfJung avatar Jul 15 '24 17:07 RalfJung

@RalfJung https://github.com/rust-lang/rust/pull/128466 got merged. This PR is no longer blocked.

TDecking avatar Aug 06 '24 22:08 TDecking

Ah, good point, thanks! :)

@bors r+

RalfJung avatar Aug 07 '24 09:08 RalfJung

:pushpin: Commit 8bf6daefb795051c3806b72ce9df3b706b022493 has been approved by RalfJung

It is now in the queue for this repository.

bors avatar Aug 07 '24 09:08 bors

:hourglass: Testing commit 8bf6daefb795051c3806b72ce9df3b706b022493 with merge 0537b14874660350c6eb217b664f106d8a2ea3c3...

bors avatar Aug 07 '24 09:08 bors

:broken_heart: Test failed - checks-actions

bors avatar Aug 07 '24 09:08 bors

Ah, maybe we need the rustup to land first.

RalfJung avatar Aug 07 '24 09:08 RalfJung

Hm, no... we had a rustup yesterday, so https://github.com/rust-lang/rust/pull/128466 should have been picked up.

RalfJung avatar Aug 07 '24 09:08 RalfJung

D'oh, this is from a Miri test directly importing the intrinsic.^^

RalfJung avatar Aug 07 '24 09:08 RalfJung

@bors r+

RalfJung avatar Aug 07 '24 09:08 RalfJung

:pushpin: Commit 3e79bb492ccc5ea3ca6249a5fd067528f9f4f40e has been approved by RalfJung

It is now in the queue for this repository.

bors avatar Aug 07 '24 09:08 bors

:hourglass: Testing commit 3e79bb492ccc5ea3ca6249a5fd067528f9f4f40e with merge 2ae377fbebe7fc762baf61e64646c2cf6927ffbc...

bors avatar Aug 07 '24 09:08 bors

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing 2ae377fbebe7fc762baf61e64646c2cf6927ffbc to master...

bors avatar Aug 07 '24 10:08 bors