miri icon indicating copy to clipboard operation
miri copied to clipboard

show warning when Stacked Borrows skips a reborrow due to 'extern type'

Open RalfJung opened this issue 1 year ago • 1 comments

When this happens, we can't actually be sure to catch all bugs -- LLVM will still get a noalias but Miri can't do reborrowing. That's not good.

Unfortunately it seems like the formatting machinery in std relies on extern type. :( So this can't land in its current shape.

RalfJung avatar Jun 22 '24 14:06 RalfJung

:umbrella: The latest upstream changes (presumably #3706) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Jun 24 '24 06:06 bors

With https://github.com/rust-lang/rust/pull/127859, this doesn't show any warnings for standard library code any more. :)

@rust-lang/miri what do you think?

RalfJung avatar Jul 24 '24 19:07 RalfJung

I think you want to update the PR description a bit. I support having a warning for this, and won't complain much if you prefer your current wording :p

saethlin avatar Jul 24 '24 19:07 saethlin

All right, let's go with this then. :)

@bors r=saethlin

RalfJung avatar Jul 24 '24 20:07 RalfJung

:pushpin: Commit 9aa0893e0f371b962388fc2b1fc5351ebe5baf79 has been approved by saethlin

It is now in the queue for this repository.

bors avatar Jul 24 '24 20:07 bors

:hourglass: Testing commit 9aa0893e0f371b962388fc2b1fc5351ebe5baf79 with merge b10b02fc1e0b134b8aa9acdb10f170f426c97df9...

bors avatar Jul 24 '24 20:07 bors

:sunny: Test successful - checks-actions Approved by: saethlin Pushing b10b02fc1e0b134b8aa9acdb10f170f426c97df9 to master...

bors avatar Jul 24 '24 21:07 bors