mdBook icon indicating copy to clipboard operation
mdBook copied to clipboard

Upgrade pulldown cmark

Open Roms1383 opened this issue 1 year ago • 2 comments

Hi and thanks for this beautiful piece of tooling, I simply love it since the first time I discovered it!

I updated pulldown-cmark but noticed the comment saying not to in Cargo.toml, so feel free to dismiss this PR if this is not supposed to happen from an external contribution.

If however you do accept this PR, I'd like to add a mathematical expression to the tests for the sake of completeness but I'd appreciate that you point me which markdown is the most appropriate, so putting this under draft for now.

Thanks!

Roms1383 avatar Jun 16 '24 03:06 Roms1383

Sorry for the ping @ehuss, but from a glance at latest commits it seem you're in charge of PRs. Any update on this ? pulldown-cmark has released a new version 0.12.0 in the meantime.

Also, saw mention in the guide of bumping version, am I allowed to do so ? Semver check recommends 0.5.0, but I imagine you would gather the changes of many a contributor first ?

Roms1383 avatar Aug 27 '24 04:08 Roms1383

As the comment says, we can't update it at this time. See #2387. We will likely update this when we do a 0.5 release.

ehuss avatar Aug 27 '24 13:08 ehuss

:umbrella: The latest upstream changes (possibly 564c80bf6dc9738ef4569ee3a822fa68ca88aacb) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot avatar May 21 '25 20:05 rustbot

CI fails on minimum MSRV, so holding back and waiting for guidance here :)

Roms1383 avatar May 22 '25 01:05 Roms1383

:umbrella: The latest upstream changes (possibly 902ded9f89e460e2d412025202e486c88c2abad9) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot avatar May 23 '25 15:05 rustbot