Cygwin: Add PTY and group API
Description
Some methods required by nix crate.
Sources
- https://github.com/cygwin/cygwin/blob/a3863bfeb73f3c3832038685498c7c4148a06890/winsup/cygwin/include/pty.h#L11-L14
- https://github.com/cygwin/cygwin/blob/a3863bfeb73f3c3832038685498c7c4148a06890/winsup/cygwin/include/cygwin/grp.h#L19
- https://github.com/cygwin/cygwin/blob/a3863bfeb73f3c3832038685498c7c4148a06890/newlib/libc/include/grp.h#L67-L78
Checklist
- [ ] Relevant tests in
libc-test/semverhave been updated - [x] No placeholder or unstable values like
*LASTor*MAXare included (see #3131) - [x] Tested locally (
cd libc-test && cargo test --target mytarget); especially relevant for platforms that may not be checked in CI
r? @tgross35
rustbot has assigned @tgross35. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
I see forkpty and openpty defined at https://github.com/cygwin/cygwin/blob/a3863bfeb73f3c3832038685498c7c4148a06890/winsup/cygwin/include/pty.h#L11-L14 and getgrouplist at https://github.com/cygwin/cygwin/blob/a3863bfeb73f3c3832038685498c7c4148a06890/winsup/cygwin/include/cygwin/grp.h#L19, but don't see getgrgid_r and the others in the directory you linked. Is https://github.com/cygwin/cygwin/blob/a3863bfeb73f3c3832038685498c7c4148a06890/newlib/libc/include/grp.h#L67-L78 the correct source?
Assuming so, lgtm. Please update the description / commit message to say what actually changed (Nix requires a lot of things)
Yes, it's the correct source. I'll update the commit message later.
I tested nix by enabling --all-features.