libc icon indicating copy to clipboard operation
libc copied to clipboard

Enable statx on musl-libc

Open neuschaefer opened this issue 1 year ago • 4 comments

Description

This PR adds the statx syscall on Linux/musl, which is available since musl 1.2.5.

Closes: https://github.com/rust-lang/libc/issues/3972

This PR is currently blocked by #3791 ~~and #3978~~.

Sources

  • https://musl.libc.org/releases.html
  • https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/stat.h

Checklist

  • [x] Relevant tests in libc-test/semver have been updated
  • [x] No placeholder or unstable values like *LAST or *MAX are included (see #3131)
  • [ ] Tested locally (cd libc-test && cargo test --target mytarget); especially relevant for platforms that may not be checked in CI

neuschaefer avatar Oct 16 '24 06:10 neuschaefer

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar Oct 16 '24 06:10 rustbot

@rustbot blocked

tgross35 avatar Nov 06 '24 21:11 tgross35

:umbrella: The latest upstream changes (presumably #4042) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Nov 16 '24 06:11 bors

:umbrella: The latest upstream changes (presumably #4132) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Nov 27 '24 00:11 bors

We now have the config musl_v1_2_3 that you could gate this under

tgross35 avatar Jul 03 '25 22:07 tgross35