libc icon indicating copy to clipboard operation
libc copied to clipboard

Add MODULE_INIT_COMPRESSED_FILE definition

Open sinkingpoint opened this issue 1 year ago • 6 comments

This adds in the definition for MODULE_INIT_COMPRESSED_FILE so that we can use it in the init_module class of functions to load compressed modules

Fixes https://github.com/rust-lang/libc/issues/3781

sinkingpoint avatar Jul 22 '24 04:07 sinkingpoint

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar Jul 22 '24 04:07 rustbot

It looks like there may be some platforms where this isn't available. Could you please take a look at the failures on the latest CI?

@rustbot author

tgross35 avatar Aug 12 '24 23:08 tgross35

It looks like MOD_INIT_COMPRESSED_FILE was added in Linux 5.17. My guess is that the arm test is failing because it's the first test that runs on a version of Linux older than that.

nathaniel-bennett avatar Aug 17 '24 16:08 nathaniel-bennett

@sinkingpoint could you rebase to get a fresh run of tests? This probably just needs something added in libc-test/build.rs to account for the kernel versions this is available on, as mentioned by @nathaniel-bennett

tgross35 avatar Nov 19 '24 23:11 tgross35

I pushed your branch with a rebase just to get fresh CI. Seems like this will need to be disabled on at least a few platforms.

tgross35 avatar Nov 21 '24 20:11 tgross35

:umbrella: The latest upstream changes (presumably #4132) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Nov 27 '24 00:11 bors

@sinkingpoint gentle ping, are you able to update this?

tgross35 avatar Apr 25 '25 03:04 tgross35

Closing as inactive, and I'm not quite sure anymore if this fits libc surface area

tgross35 avatar Aug 10 '25 05:08 tgross35