libc icon indicating copy to clipboard operation
libc copied to clipboard

vxWorks adding few errnoLib related constants.

Open devnexen opened this issue 1 year ago • 1 comments

devnexen avatar Jul 21 '24 15:07 devnexen

r? @JohnTitor

rustbot has assigned @JohnTitor. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Jul 21 '24 15:07 rustbot

https://github.com/rust-lang/rust/pull/128751 makes use of VX_TASK_NAME_LEN. Is that something defined in libc?

tgross35 avatar Aug 06 '24 20:08 tgross35

I m unsure it s possible yet due to the uncertainty of its value unless a minimum vxworks release is supported.

devnexen avatar Aug 06 '24 20:08 devnexen

It may be worth specifying a minimum version, even if old, to make it obvious which APIs can be relied upon. If you are up for this, just make a PR to document some minimum version in https://github.com/rust-lang/rust/blob/60d146580c10036ce89e019422c6bc2fd9729b65/src/doc/rustc/src/platform-support/vxworks.md. Then we can ping a handful of people who have been involved in VxWorks to get their feedback.

tgross35 avatar Aug 06 '24 20:08 tgross35

CI has some known problems. We're working on getting those sorted out (will need to do that before merge)

tgross35 avatar Aug 08 '24 17:08 tgross35

I m unsure it s possible yet due to the uncertainty of its value unless a minimum vxworks release is supported.

Does that work now with the minimum version of 7?

tgross35 avatar Aug 09 '24 15:08 tgross35

I m unsure it s possible yet due to the uncertainty of its value unless a minimum vxworks release is supported.

Does that work now with the minimum version of 7?

Yes. VX_TASK_NAME_LEN is now 31.

biabbas avatar Aug 12 '24 11:08 biabbas

it had been added in the last commit

devnexen avatar Aug 12 '24 11:08 devnexen

Not going to block on this since it is tier 3, but it may be worth adding a vxworks file in libc-test/semver.

tgross35 avatar Aug 12 '24 18:08 tgross35