libc icon indicating copy to clipboard operation
libc copied to clipboard

Disable `libregex` for QNX 7.0

Open nyurik opened this issue 1 year ago • 5 comments

libregex did not exist until QNX 7.1. Before that, the regex functions were part of the libc.

At the moment, this is a NOOP because nto70 only supports no_std.

I am working on backporting std support to 7.0, and hit this bug. See https://github.com/rust-lang/rust/pull/127897

nyurik avatar Jul 18 '24 16:07 nyurik

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar Jul 18 '24 16:07 rustbot

r=me once CI passes.

joshtriplett avatar Jul 18 '24 17:07 joshtriplett

@joshtriplett thx for the review and comment fix. CI seems to be failing on something unrelated

nyurik avatar Jul 18 '24 17:07 nyurik

@joshtriplett let me know if there is anything else needed here - the CI seem to be failing for unrelated reasons. This PR is needed to merge QNX 7.0 support into the compiler. Thx!

nyurik avatar Jul 20 '24 15:07 nyurik

r? @joshtriplett

nyurik avatar Jul 24 '24 14:07 nyurik