libc icon indicating copy to clipboard operation
libc copied to clipboard

add `pthread_equal`

Open joboet opened this issue 1 year ago • 1 comments

From its documentation:

The pthread_equal() function is necessary because thread IDs should be considered opaque: there is no portable way for applications to directly compare two pthread_t values.

joboet avatar Jul 18 '24 12:07 joboet

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar Jul 18 '24 12:07 rustbot

Can you change this to target main? Can cherry pick to stable after merge.

@rustbot label +stable-nominated

tgross35 avatar Aug 12 '24 21:08 tgross35

:umbrella: The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Aug 12 '24 22:08 bors

I don't know why freebsd would have failed, it should be available https://man.freebsd.org/cgi/man.cgi?query=pthread_equal&sektion=3.

edit: looks like maybe it was something spurious or just had the outdated CI job. Will try with this rebase.

tgross35 avatar Aug 12 '24 22:08 tgross35