libc icon indicating copy to clipboard operation
libc copied to clipboard

feat: add missing netfilter consts

Open my4ng opened this issue 8 months ago • 1 comments

This PR adds some missing netfilter constants from:

  • linux/netfilter.h
  • linux/netfilter_arp.h
  • linux/netfilter_bridge.h
  • linux/netfilter_ipv4.h
  • linux/netfilter_ipv6.h

Unresolved questions:

  • [ ] NF_NETDEV_NUMHOOKS and NF_NETDEV_INGRESS were not moved from semver/linux-gnu.txt to semver/linux.txt during #2152. Should that be rectified now?
  • [ ] NF_NETDEV_NUMHOOKS value was changed from 1 to 2 in linux kernel 5.16 (https://github.com/torvalds/linux/commit/42df6e1d221dddc0f2acf2be37e68d553ad65f96) and hence some workaround was added to libc_test/build.rs: https://github.com/rust-lang/libc/blob/acc7bb1a38e2b9d6a18f28279d80d464c4c25089/libc-test/build.rs#L1842 https://github.com/rust-lang/libc/blob/acc7bb1a38e2b9d6a18f28279d80d464c4c25089/libc-test/build.rs#L3940 Is it OK to chnage them to 2 now and remove those lines or do we have to maintain some level of backwards-compatibility?
  • [x] Similarly, what about new constants introduced later, e.g. NF_IP_PRI_RAW_BEFORE_DEFRAG introduced in 5.10?

my4ng avatar Jun 05 '24 07:06 my4ng