libc icon indicating copy to clipboard operation
libc copied to clipboard

Unify the ioctl declarations on linux

Open espindola opened this issue 1 year ago • 1 comments

I originally wanted to have all versions take a c_uint, since that is what the kernel expects on the other side. I then found that the test infrastructure, quite reasonably, enforces that the symbol matches what the C library provides.

So this PR is now just a small cleanup that uses the existing Ioctl type to reduce duplication.

espindola avatar May 25 '24 20:05 espindola

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar May 25 '24 20:05 rustbot

:umbrella: The latest upstream changes (presumably #3777) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Aug 14 '24 18:08 bors

This is a nice cleanup, thanks. Could you double check that the tests in libc-test/semver are up to date?

I can't run the tests, since ctest2 complains that

  unknown os/family: x86_64-alpine-linux-musl
``

But they passed on CI and I didn't change what gets exported.

espindola avatar Aug 15 '24 11:08 espindola

But they passed on CI and I didn't change what gets exported.

In fact, ioctl is listed in unix.txt, so it is already expected everywhere.

espindola avatar Aug 15 '24 11:08 espindola

Thanks for confirming!

tgross35 avatar Aug 15 '24 17:08 tgross35