Add missing staff for Illumos/Solaris as used in quinn
r? @JohnTitor
rustbot has assigned @JohnTitor. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Some changes occurred in solarish module
cc @jclulow, @pfmooney
libc-test still passes on illumos with this change in place
@JohnTitor can you please have look at this? Thank you!
@JohnTitor is there anything wrong with this pull request?
r? @tgross35
Can you please help with merging of this?
I am not sure what to check against, are there docs/headers online for the constants? Changes themselves look fine to me with one nit above.
Please rebase and squash so the merge commits go away.
(Also, I assume the PR title and commit is meant to say "add missing stuff". Please make this more descriptive, e.g. "Add missing networking support for solaris".)
I am not sure what to check against, are there docs/headers online for the constants?
The only way how to review header files I can think of is:
- Login to Solaris 11.4 machines as they are available at https://portal.cfarm.net/machines/list/
- Install Solaris CBE release per https://blogs.oracle.com/solaris/post/announcing-the-first-oracle-solaris-114-cbe
I don't have a cfarm account so that would take a couple days. Since @pfmooney has already verified illumos, I have no objection to merging.
This should have an update libc-test/semver, otherwise LGTM.
@rustbot author