libc icon indicating copy to clipboard operation
libc copied to clipboard

Add missing staff for Illumos/Solaris as used in quinn

Open psumbera opened this issue 1 year ago • 5 comments

psumbera avatar May 22 '24 14:05 psumbera

r? @JohnTitor

rustbot has assigned @JohnTitor. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar May 22 '24 14:05 rustbot

Some changes occurred in solarish module

cc @jclulow, @pfmooney

rustbot avatar May 22 '24 14:05 rustbot

libc-test still passes on illumos with this change in place

pfmooney avatar May 22 '24 17:05 pfmooney

@JohnTitor can you please have look at this? Thank you!

psumbera avatar Jun 18 '24 07:06 psumbera

@JohnTitor is there anything wrong with this pull request?

psumbera avatar Jul 04 '24 13:07 psumbera

r? @tgross35

Can you please help with merging of this?

psumbera avatar Aug 12 '24 16:08 psumbera

I am not sure what to check against, are there docs/headers online for the constants? Changes themselves look fine to me with one nit above.

Please rebase and squash so the merge commits go away.

(Also, I assume the PR title and commit is meant to say "add missing stuff". Please make this more descriptive, e.g. "Add missing networking support for solaris".)

tgross35 avatar Aug 12 '24 16:08 tgross35

I am not sure what to check against, are there docs/headers online for the constants?

The only way how to review header files I can think of is:

  1. Login to Solaris 11.4 machines as they are available at https://portal.cfarm.net/machines/list/
  2. Install Solaris CBE release per https://blogs.oracle.com/solaris/post/announcing-the-first-oracle-solaris-114-cbe

psumbera avatar Aug 12 '24 21:08 psumbera

I don't have a cfarm account so that would take a couple days. Since @pfmooney has already verified illumos, I have no objection to merging.

This should have an update libc-test/semver, otherwise LGTM.

tgross35 avatar Aug 12 '24 21:08 tgross35

@rustbot author

tgross35 avatar Aug 12 '24 23:08 tgross35