libc icon indicating copy to clipboard operation
libc copied to clipboard

Add `SYS_lseek` and `SYS_mmap` for aarch64 Android

Open lberrymage opened this issue 1 year ago • 2 comments

Values are sourced from https://android.googlesource.com/platform/bionic/+/0339184/libc/kernel/uapi/asm-generic/unistd.h.

I noticed these constants were missing when compiling for the aarch64-linux-android target.

I'm not entirely sure whether I added the semver tests correctly, so please let me know if those need changes.

lberrymage avatar Mar 25 '24 22:03 lberrymage

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar Mar 25 '24 22:03 rustbot

The CI failures appear to be unrelated:

  = note: /usr/lib/gcc-cross/aarch64-linux-gnu/13/../../../../aarch64-linux-gnu/bin/ld: /rust/lib/rustlib/aarch64-unknown-linux-musl/lib/libstd-55a85b3d629131f6.rlib(std-55a85b3d629131f6.std.e271c4a0ea64dd3f-cgu.0.rcgu.o): in function `std::sys::pal::unix::thread::Thread::get_name':
          /rustc/0824b300eb0dae5d9ed59719d3f2732016683d66/library/std/src/sys/pal/unix/thread.rs:233:(.text._ZN3std3sys3pal4unix6thread6Thread8get_name17h151b5832ae5a589dE+0x30): undefined reference to `pthread_getname_np'
          collect2: error: ld returned 1 exit status
          
  = note: some `extern` functions couldn't be found; some native libraries may need to be installed or have their path specified
  = note: use the `-l` flag to specify native libraries to link
  = note: use the `cargo:rustc-link-lib` directive to specify the native libraries to link with Cargo (see https://doc.rust-lang.org/cargo/reference/build-scripts.html#rustc-link-lib)

lberrymage avatar Mar 25 '24 23:03 lberrymage

Could you rebase? The CI failure has been fixed on the latest libc-0.2 branch.

JohnTitor avatar Apr 29 '24 09:04 JohnTitor

Rebased and CI is now passing.

lberrymage avatar Apr 29 '24 23:04 lberrymage