libc icon indicating copy to clipboard operation
libc copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

Remove placeholder constants

Open Lilit0x opened this issue 3 months ago • 2 comments

This PR removes placeholder constants as described in #3131. Below are lists of patterns matched for unused constant names. It also includes an update of the IPROTO_MAX constant on newer versions of Linux mentioned in #1896.

  • _COUNT
  • _MAX
  • _NUM

These are all breaking changes for the new libc 1.0 version tracked in #3248

Lilit0x avatar Mar 14 '24 15:03 Lilit0x

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar Mar 14 '24 15:03 rustbot

Some changes occurred in solarish module

cc @jclulow, @pfmooney

rustbot avatar Mar 15 '24 11:03 rustbot

Closing as inactive, it'd be great if you could split PRs to make our review easy. Thank you for the PR anyway!

JohnTitor avatar Apr 29 '24 19:04 JohnTitor

Closing as inactive, it'd be great if you could split PRs to make our review easy. Thank you for the PR anyway!

Yeahh, I paused on it because some clarification is needed based on my discussion with @Amanieu .

Lilit0x avatar Apr 29 '24 20:04 Lilit0x