libc icon indicating copy to clipboard operation
libc copied to clipboard

Add ALG_SET_DRBG_ENTROPY and ALG_SET_KEY_BY_KEY_SERIAL constants

Open rzimmerman opened this issue 1 year ago • 5 comments

ALG_SET_KEY_BY_KEY_SERIAL was added in Linux 6.2: https://elixir.bootlin.com/linux/v6.2.16/source/include/uapi/linux/if_alg.h#L54

Also adding ALG_SET_DRBG_ENTROPY for completeness.

rzimmerman avatar Sep 01 '23 19:09 rzimmerman

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar Sep 01 '23 19:09 rustbot

Regarding the test failures, I think the jammy package for linux-headers is still tied to kernel version 5.15, so this constant is missing.

rzimmerman avatar Sep 02 '23 01:09 rzimmerman

:umbrella: The latest upstream changes (presumably #3404) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Oct 28 '23 07:10 bors

We recently updated Ubuntu images to 23.10, please rebase onto main. Note that our musl header is old and you would have to tweak https://github.com/rust-lang/libc/blob/main/libc-test/build.rs.

JohnTitor avatar Nov 09 '23 15:11 JohnTitor

@rzimmerman are you able to rebase to finish this?

tgross35 avatar Aug 29 '24 11:08 tgross35