impl-trait-utils icon indicating copy to clipboard operation
impl-trait-utils copied to clipboard

Support omitting the variant name

Open traviscross opened this issue 1 year ago • 2 comments

Let's say that we want to create a Send variant of a trait but we don't need a non-Send variant of that trait at all. We could of course just write that trait, but adding the Send bounds in all the right places could be annoying.

In this commit, we allow simply omitting the new variant name from the call to make. When called that way, we use the name from the item to emit only one variant with the bounds applied. We don't emit the original item.

For completeness and explicit disambiguation, we support prefixing the bounds with a colon (but giving no variant name). Similarly, for completeness, we support giving the same name as the trait item. In both of these cases, we just emit the one variant. Since these are for completeness, we don't advertise these syntaxes in the documentation.

That is, we now support:

  • make(NAME: BOUNDS)
  • make(NAME:)
  • make(:BOUNDS)
  • make(BOUNDS)

This resolves #18.

traviscross avatar Feb 10 '24 00:02 traviscross

@traviscross These tests look great. Would you mind rebasing now that #27 is merged?

tmandry avatar Feb 13 '24 18:02 tmandry

Any movement on that?

Sytten avatar Apr 29 '24 13:04 Sytten