homu icon indicating copy to clipboard operation
homu copied to clipboard

Implement the bors auto r?eassignment on r+ policy

Open Centril opened this issue 6 years ago • 4 comments

See:

  • https://github.com/rust-lang/rust/issues/59489
  • https://github.com/rust-lang/rust/issues/59489#issuecomment-478589583

Centril avatar May 30 '19 21:05 Centril

cc @kennytm

Centril avatar May 30 '19 21:05 Centril

Do you expect homu to set the assignee directly? Or do you expect homu to leave a r? at-person comment?

bryanburgers avatar Jun 04 '19 00:06 bryanburgers

The former would generate least noise in terms of pings so it seems be preferable but the latter is also workable.

Centril avatar Jun 04 '19 00:06 Centril

For anyone looking to work on this, you'll want to assign the new reviewer here: https://github.com/rust-lang/homu/blob/91da2d8e74d2140222f3e6a48f8442be9ef34331/homu/main.py#L567-L578 I'm not sure if bors already has a way to assign a reviewer, though, as @rust-highfive is usually responsible for that. Alternatively, it might be easier for @rust-highfive to do.

varkor avatar Sep 10 '19 15:09 varkor