highfive icon indicating copy to clipboard operation
highfive copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

Enable retry choose_reviewer

Open h-michael opened this issue 6 years ago • 3 comments

Sometimes, highfive fails assign reviewer. ex(https://github.com/rust-lang/rust/pull/57913) If PR owner doesn't know appropriate reviewer, they can't write r? by themselves. So I want the way that re choose_reviewer action. Something like r? _retry, r? _.(We can't use underscore to Github username)

h-michael avatar Jan 26 '19 12:01 h-michael

Thanks for reporting this! I'd prefer if we fix the underlying cause of highfive crashing instead of adding patches to retry failures though. That specific crash was caused by https://github.com/rust-lang-nursery/highfive/issues/190.

pietroalbini avatar Jan 26 '19 14:01 pietroalbini

I think the better workaround for #190 is https://github.com/rust-lang-nursery/highfive/issues/187.

dwijnand avatar Mar 02 '19 11:03 dwijnand

I’ve opened https://github.com/rust-lang/highfive/issues/241 for a different use case, but the requested functionality is the same as here.

SimonSapin avatar Dec 27 '19 13:12 SimonSapin