glob icon indicating copy to clipboard operation
glob copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

Style fixes

Open samueltardieu opened this issue 1 year ago • 3 comments

Apply various style fixes found by Clippy:

  • Do not deconstruct an error to rebuild it right after
  • Remove useless as usize
  • Use char rather than &str as starts_with() argument
  • Remove useless references

samueltardieu avatar Dec 22 '23 20:12 samueltardieu

I have separated the style fixes into various commits so that some could be removed if the maintainers prefer to let the code this way. This can be the case for the "Remove useless as usize" for example, as even though I don't find !0 as usize more readable than !0 (or usize::MAX as I would have used myself), some others may differ.

samueltardieu avatar Dec 22 '23 20:12 samueltardieu

Rebased on current master branch.

samueltardieu avatar Jan 07 '24 09:01 samueltardieu

Is this a real failure? MacOS jobs just display "This job failed" without any info, did the jobs start?

samueltardieu avatar Sep 10 '24 06:09 samueltardieu