git2-rs icon indicating copy to clipboard operation
git2-rs copied to clipboard

Add support for SSH interactive authentication

Open exactly-one-kas opened this issue 3 years ago • 1 comments

For lifetime reasons, Cred now doesn't always carry a git_cred and therefore Cred::unwrap() may now panic if called on a Cred created using Cred::ssh_interactive(); this is the only backwards-incompatible change

Without leaking memory or memorizing created handlers in RemoteCallbacks it's not possible to have individual handler for each SSH interactive Cred, so I compromized and put the handler directly into RemoteCallbacks

Also, since libgit2 only ships with dummy typedefs for LIBSSH2_USERAUTH_KBDINT_PROMPT and LIBSSH2_USERAUTH_KBDINT_PROMPT, libssh2-sys is now a direct dependency for the ssh feature

exactly-one-kas avatar Aug 13 '22 07:08 exactly-one-kas

:umbrella: The latest upstream changes (possibly f0951122c88ba30b48a98b4b5e9f6670daa57ad8) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot avatar Jan 20 '25 16:01 rustbot