futures-rs icon indicating copy to clipboard operation
futures-rs copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

Implement Deref{Mut} for AllowStdIo.

Open Frostie314159 opened this issue 1 year ago • 2 comments

This PR adds Deref{Mut} which internally just call get_{ref|mut}, which will stay, as to not break compatibility.

Frostie314159 avatar Dec 06 '23 17:12 Frostie314159

The clippy lint as well as the rustdoc crash appear to be unrelated to this PR, does anyone know why they are happening. I tested it against the latest nightly version of clippy and rustdoc and both succeed with out warnings.

Frostie314159 avatar Dec 06 '23 17:12 Frostie314159

The bug causing the CI failure was patched in the latest release of rustdoc.

Frostie314159 avatar Dec 13 '23 11:12 Frostie314159

I think this could cause breakage if a different method with the same name as a method in std::io traits is added to futures::io traits.

taiki-e avatar Feb 26 '24 14:02 taiki-e

Closing this due to the above concern.

Thanks anyway for the PR!

taiki-e avatar Feb 26 '24 15:02 taiki-e