docs.rs icon indicating copy to clipboard operation
docs.rs copied to clipboard

Add registry-watcher image and separate docker-compose services

Open Nemo157 opened this issue 2 years ago • 7 comments

Creates a separate image for the registry-watcher, setup to run the correct command. Reconfigures the docker-compose setup to use the web-server image and this new registry-watcher image as intended to be used in the new production infrastructure, along with a new build-server image that is close to what will be used in the new production infrastructure, replicated twice.

Nemo157 avatar Oct 13 '23 21:10 Nemo157

Probably needs some infra input on the deploy changes (what exactly the tags they use will be). Also I want to investigate the crates.io-index initialization a little more and make sure that's working (and probably have it be local to each container instead of shared as it is now).

Nemo157 avatar Oct 13 '23 21:10 Nemo157

Thank you for working on this @Nemo157 !

Sorry for already adding a review in the draft-stage, but I thought some feedback would already help :)

syphar avatar Oct 14 '23 09:10 syphar

I have removed the CI changes pushing the new image to production, since that will require some input from infra and can be done later.

Nemo157 avatar Nov 15 '23 16:11 Nemo157

short test result:

  • trying to run the registry watcher gives me /usr/bin/tini: invalid option -- '-'

syphar avatar Nov 17 '23 16:11 syphar

Fixed that, I was normalizing the COMMANDs and thought that the -- wasn't actually needed with tini. I've normalized them the other way and split the ENTRYPOINT and COMMAND so that it's possible to run other cratesfyi commands under any image.

Nemo157 avatar Nov 18 '23 11:11 Nemo157

Fixed that, I was normalizing the COMMANDs and thought that the -- wasn't actually needed with tini. I've normalized them the other way and split the ENTRYPOINT and COMMAND so that it's possible to run other cratesfyi commands under any image.

I'm still seeing the same error when trying to run the registry watcher container?

syphar avatar Nov 19 '23 06:11 syphar

I'm still seeing the same error when trying to run the registry watcher container?

Coming back to this finally, are you using --build with the docker compose up call? It doesn't have any kind of change detection and requires you to tell it to rebuild. I've added that to the comment about how to run it.

Nemo157 avatar Mar 19 '24 14:03 Nemo157