crates.io icon indicating copy to clipboard operation
crates.io copied to clipboard

WIP: Add `PATCH /crates/:crate/:version` route

Open 0xPoe opened this issue 1 year ago • 2 comments

ref https://github.com/rust-lang/crates.io/issues/9193

This pull request introduces a new patch API for yanking and unyanking crates with a message.

The logic is very similar to the current yank and unyank API, but it supports setting a yank message.

0xPoe avatar Sep 10 '24 13:09 0xPoe

Codecov Report

Attention: Patch coverage is 98.49246% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.11%. Comparing base (d02745c) to head (45ec3fb). Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/controllers/version/metadata.rs 97.02% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9423      +/-   ##
==========================================
+ Coverage   89.05%   89.11%   +0.06%     
==========================================
  Files         285      285              
  Lines       28757    28920     +163     
==========================================
+ Hits        25610    25773     +163     
  Misses       3147     3147              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 10 '24 13:09 codecov[bot]

I've rebased this on top of https://github.com/rust-lang/crates.io/pull/9437 to get that first part out of the way and make the PR a bit easier to review :)

Turbo87 avatar Sep 12 '24 20:09 Turbo87

:umbrella: The latest upstream changes (presumably #9505) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Sep 25 '24 01:09 bors

:umbrella: The latest upstream changes (presumably 60d3cfef1ded36386a04b907e84cef21a5b87a9d) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Sep 27 '24 07:09 bors

I rebased the branch and fixed the above two comments. I think this is good to go now :)

Turbo87 avatar Sep 30 '24 11:09 Turbo87