crates.io icon indicating copy to clipboard operation
crates.io copied to clipboard

CI: Add e2e test

Open eth3lbert opened this issue 1 year ago • 6 comments

This is a follow-up PR to #8521 and add e2e test into our CI.

eth3lbert avatar May 24 '24 08:05 eth3lbert

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.47%. Comparing base (26c9e28) to head (10b5f24). Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8714      +/-   ##
==========================================
+ Coverage   88.45%   88.47%   +0.01%     
==========================================
  Files         276      276              
  Lines       27449    27449              
==========================================
+ Hits        24281    24285       +4     
+ Misses       3168     3164       -4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 24 '24 08:05 codecov[bot]

It seems like the screenshot doesn't match the expected behavior. This could be because Ember tests and Playwright use different screen resolutions. I'll dig into this further to investigate.

eth3lbert avatar May 24 '24 09:05 eth3lbert

it looks like it was previously not loading the FiraSans font and with playwright it is loading it, which results in different font rendering.

Turbo87 avatar May 24 '24 09:05 Turbo87

it looks like it was previously not loading the FiraSans font and with playwright it is loading it, which results in different font rendering.

Thanks for looking that up! That's interesting. Should we align with the Ember side and add a fixture to block the font resource, or fix it later on the Ember side?

eth3lbert avatar May 24 '24 10:05 eth3lbert

I'd just leave it as is for now. if we notice that it causes actual problems we can still address it later. once we merge this branch the loaded font will be the new baseline.

Turbo87 avatar May 24 '24 10:05 Turbo87

Now it should work!

eth3lbert avatar May 24 '24 12:05 eth3lbert