crates.io icon indicating copy to clipboard operation
crates.io copied to clipboard

Dark mode search button colors too aggressive

Open alerque opened this issue 1 year ago • 2 comments

The new dark mode is great to have, but some of the color choices are a bit jaring. It feels like some things are leftover from a different theme, not a design choice for the dark theme.

For example the search button in the header and home page is way too bright and overpowers everything on any page, including the logo.

image

In fact the other yellow button colors are much more subdued, some of them perhaps too muted and inconsistent:

image

Of these the two big buttons from the home page look about right, but the "follow" buttons seem too muted and the "search" buttons seem to bright.

alerque avatar May 18 '24 11:05 alerque

I also find the text colour is too bright. And possibly the background is too dark?

image

rope-hmg avatar May 24 '24 12:05 rope-hmg

@rope-hmg I would suggest a different issue, that's really a different discussion. Personally I think the contrast shown is fine and wouldn't want to see it muted more. This issue is about outliers that are outside the overall range of most of the theme.

alerque avatar May 24 '24 13:05 alerque

Ah yes. The dark mode is not good, but talking about how the dark mode isn't good isn't relevant. Yep, I see it.

Seems to me like it's very reasonable to mention some of the colour choices being too bright. Especially when you yourself said "but some of the color choices are a bit jaring".

Considering my complaint about these colours is the same as yours maybe this is the right issue to mention them?

rope-hmg avatar Jun 01 '24 21:06 rope-hmg

It feels like some things are leftover from a different theme, not a design choice for the dark theme.

while not necessarily intentional, the current color seems to fit okayish IMHO. since it's also one of our somewhat unofficial brand colors I'm not sure that we really want to change it.

I also find the text colour is too bright. And possibly the background is too dark?

the current color scheme has reasonably good contrast. if we move to light-grey on dark-grey this will be significantly worse.

ultimately, this is a bikeshed discussion and we won't be able to please everyone. I'd be very happy if a professional designer got involved and helped us improve the design of the entire page, but until that is the case we all have to live with the current level of beauty 😅

Turbo87 avatar Jun 17 '24 13:06 Turbo87