crates.io icon indicating copy to clipboard operation
crates.io copied to clipboard

Allow crate version deletion in the first 24 hours from creation

Open nappa85 opened this issue 3 years ago • 7 comments

Adds route DELETE /api/v1/crates/:crate_id

Resolves #5293

nappa85 avatar Oct 08 '22 07:10 nappa85

@nappa85 just for awareness: https://github.com/rust-lang/crates.io/issues/5293#issuecomment-1272406916

tl;dr I'm not sure whether we should allow crate deletion, or if it makes more sense for us to allow version deletion, and then if there is no version left the crate automatically gets deleted too.

Turbo87 avatar Oct 09 '22 18:10 Turbo87

@nappa85 just for awareness: #5293 (comment)

tl;dr I'm not sure whether we should allow crate deletion, or if it makes more sense for us to allow version deletion, and then if there is no version left the crate automatically gets deleted too.

Updated, let me know if there is anything else

nappa85 avatar Oct 10 '22 08:10 nappa85

I think there is some work left on correctly syncing both the git and the http index after the deletion. But before we continue, I talked to a few people about this and since it is a quite significant change we might actually require to go through the RFC process for it since other people are currently relying on the fact that crates don't just disappear like that again.

Turbo87 avatar Oct 13 '22 11:10 Turbo87

and just to be clear, I'm very thankful for the quick implementation! I just want to make sure we're not we're not surprising too many people with this change :)

Turbo87 avatar Oct 13 '22 11:10 Turbo87

and just to be clear, I'm very thankful for the quick implementation! I just want to make sure we're not we're not surprising too many people with this change :)

Understandable, don't worry

nappa85 avatar Oct 13 '22 13:10 nappa85

:umbrella: The latest upstream changes (presumably 802f7ec392cdb63b579b34c80a2036b8c62a8b9b) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Jan 03 '23 21:01 bors

Something nasty happened during the rebase, probably better restart from scratch...

nappa85 avatar Feb 03 '23 15:02 nappa85

FWIW there is now an RFC for this: https://github.com/rust-lang/rfcs/pull/3660

since the implementation will need a couple of changes (and rebases) I'll close this PR and will use it as inspiration when implementing the RFC spec :)

Turbo87 avatar Jul 12 '24 12:07 Turbo87